Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Asciidoctorj Diagram and PlantUML Dependencies #1525

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

cachescrubber
Copy link
Contributor

@cachescrubber cachescrubber commented Feb 4, 2024

Upgrade Asciidoctorj Diagram and PlantUML Dependencies

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Upgrade Dependencies

I would like to upgrade asciidoctorj-diagram to 2.2.17 and asciidoctorj-diagram-plantuml to 1.2023.13 in order to use the latest fixes and features from the IntelliJ plugin.

Does this PR introduce a breaking change?

  • No
  • Yes

@ahus1 ahus1 merged commit b4e6663 into asciidoctor:main Feb 4, 2024
@ahus1
Copy link
Contributor

ahus1 commented Feb 4, 2024

Thank you for this update! I'll include it in the next release and I will update this PR once it is available.

Do you think it would make sense to offer a semi-automated download for Structurizer CLI from the plugin? I didn't look in Asciidoctor Diagram's source code yet - if it is ready an environment variable that is needed, this would be difficult to achieve as a Java Process can't change its own environment variables. Using an attribute (preferred, can be set per document) or a Java system property (can be set on a JVM globally) would enable this.

@ahus1
Copy link
Contributor

ahus1 commented Feb 4, 2024

I've triggered pre-release 0.41.7 which should be available on the JetBrains marketplace shortly.

The pre-release of the plugin is available from GitHub releases and the IntelliJ AsciiDoc EAP repository.

@cachescrubber
Copy link
Contributor Author

Many thanks for merging and releasing the preview!

Regarding the download:

Since the integration is via Asciidoctorj, reading the documentation, it should be possible to use a Java system property derived from the environment variable: diagram.structurizrcli.home . Reading the source it is also possible to pass in a class path list directly, via the DIAGRAM_STRUCTURIZR_CLASSPATH / diagram.structurizrcli.classpath variable.

Since the implementation in asciidoctor-diagram-java is implemented as a java library - and not really using the command line interface - , it should be possible to download a small number of jar files from maven central and pass them via diagram.structurizrcli.classpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants