Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completion for attributes + built-in attributes doc. fix #243 #277

Merged
merged 2 commits into from
Jun 23, 2019
Merged

Auto-completion for attributes + built-in attributes doc. fix #243 #277

merged 2 commits into from
Jun 23, 2019

Conversation

bbrenne
Copy link
Contributor

@bbrenne bbrenne commented Jun 21, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing documents:

The PR fulfills these requirements:

If adding a new feature:

Other information:

@bbrenne
Copy link
Contributor Author

bbrenne commented Jun 21, 2019

Known bug: some attribute description are bugged due to the presence of html tags in them, I did'nt find a way to escape them yet.

@ahus1 ahus1 self-assigned this Jun 22, 2019
@ahus1
Copy link
Contributor

ahus1 commented Jun 22, 2019

Looks great! I am testing it for some corner cases and I started to prepare a commit to fix the HTML escaping. I will merge it over the next one or two days.

@ahus1 ahus1 merged commit 7e530be into asciidoctor:master Jun 23, 2019
@ahus1
Copy link
Contributor

ahus1 commented Jun 23, 2019

I've squashed your commits with the code style and test fixes. I've added:

  • selecting an entry from autocomplete for a built-in attribute that is replacing an attribute with a dash (will replace complete existing attribute instead of the first part)
  • adding a ":" or a "}" only when there is not there already
  • escaping of HTML
  • documentation is now also available on attributes and attribute references in the editor (not only during autocomplete)
  • a PSI unit test
  • updated documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants