-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of syntax highlighting for asciidoc #73
Conversation
initial implementation of syntax highlighting for asciidoc
Hi Dmitry, thank you for this great contribution! |
There's more to come. :) |
Looking forward to it! This feature will be an important building block for so many extra features! |
This is very exciting. We really need a grammar / reference parser for the AsciiDoc syntax and this another step down that road. What might help to get other people involved (including myself) is to start creating an acceptance testing suite for what the grammar matches so that we can review and validate that it's accurate. I feel like there's a lot of stuff about AsciiDoc parsing that's stuck in my head and with a test suite I can follow, it will help me help you with the details. Thanks again for kicking off this initiative! |
To clarify my comment about the test suite, I see that there is a low-level unit test but I was thinking about something more along the lines of a document-oriented test that's a bit easier to study. Having said that, I do think the unit test is a good start. |
Dan, good comments! And while I agree with you, I feel that the discussion of creating a grammar / reference parser can better take part in it's own topic in the issue tracker or on the AsciiDoc forum, instead of the comments for the IntelliJ parser, agreed? |
@harrol Completing this makes implementing the Scratch files also possible! |
Yes, I agree. I'm just pointing out that this is closely related and decisions will need to be made in the process of creating this lexer regardless. |
As for me, I'm afraid I won't have time to implement a comprehensive lexer/parser that supports all asciidoc features. I'm sorely missing basic syntax highlighting, structure view and a couple of inspections when working on my book project, but I'm only using a subset of features of the markup, and once I have those covered, I'll have to focus on the book and not on improving the plugin further. Of course, this should still work as a foundation for other people to build upon. |
Exactly. That's how we roll. |
No description provided.