Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of syntax highlighting for asciidoc #73

Merged
merged 1 commit into from
Jul 20, 2015

Conversation

yole
Copy link
Contributor

@yole yole commented Jul 20, 2015

No description provided.

bodiam added a commit that referenced this pull request Jul 20, 2015
initial implementation of syntax highlighting for asciidoc
@bodiam bodiam merged commit 8078419 into asciidoctor:master Jul 20, 2015
@bodiam
Copy link
Contributor

bodiam commented Jul 20, 2015

Hi Dmitry, thank you for this great contribution!

@yole
Copy link
Contributor Author

yole commented Jul 20, 2015

There's more to come. :)

@bodiam
Copy link
Contributor

bodiam commented Jul 20, 2015

Looking forward to it! This feature will be an important building block for so many extra features!

@mojavelinux
Copy link
Member

This is very exciting. We really need a grammar / reference parser for the AsciiDoc syntax and this another step down that road.

What might help to get other people involved (including myself) is to start creating an acceptance testing suite for what the grammar matches so that we can review and validate that it's accurate. I feel like there's a lot of stuff about AsciiDoc parsing that's stuck in my head and with a test suite I can follow, it will help me help you with the details.

Thanks again for kicking off this initiative!

@mojavelinux
Copy link
Member

To clarify my comment about the test suite, I see that there is a low-level unit test but I was thinking about something more along the lines of a document-oriented test that's a bit easier to study. Having said that, I do think the unit test is a good start.

@bodiam
Copy link
Contributor

bodiam commented Jul 20, 2015

Dan, good comments! And while I agree with you, I feel that the discussion of creating a grammar / reference parser can better take part in it's own topic in the issue tracker or on the AsciiDoc forum, instead of the comments for the IntelliJ parser, agreed?

@bodiam
Copy link
Contributor

bodiam commented Jul 20, 2015

@harrol Completing this makes implementing the Scratch files also possible!

@mojavelinux
Copy link
Member

I feel that the discussion of creating a grammar / reference parser can better take part in it's own topic...

Yes, I agree. I'm just pointing out that this is closely related and decisions will need to be made in the process of creating this lexer regardless.

@yole
Copy link
Contributor Author

yole commented Jul 21, 2015

As for me, I'm afraid I won't have time to implement a comprehensive lexer/parser that supports all asciidoc features. I'm sorely missing basic syntax highlighting, structure view and a couple of inspections when working on my book project, but I'm only using a subset of features of the markup, and once I have those covered, I'll have to focus on the book and not on improving the plugin further.

Of course, this should still work as a foundation for other people to build upon.

@mojavelinux
Copy link
Member

this should still work as a foundation for other people to build upon.

Exactly. That's how we roll.

@harrol
Copy link
Contributor

harrol commented Jul 25, 2015

@yole Very cool! @bodiam Let's have a look at scratch files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants