Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of parser, PSI and structure view for AsciiDoc #74

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

yole
Copy link
Contributor

@yole yole commented Jul 21, 2015

No description provided.

@bodiam
Copy link
Contributor

bodiam commented Jul 21, 2015

Hi Dmitry! Thanks again. Is this already doing basic syntax highlighting? Or does it need even more?

bodiam added a commit that referenced this pull request Jul 21, 2015
initial implementation of parser, PSI and structure view for AsciiDoc
@bodiam bodiam merged commit 51ab794 into asciidoctor:master Jul 21, 2015
@mojavelinux
Copy link
Member

Or does it need even more?

I'm sure it will always need more as the syntax for AsciiDoc goes pretty deep. However, as Dmitry has pointed out, just having the basic structure covered already helps a tremendous amount. We just need to chip away at it a bit at a time and eventually the coverage will come.

@bodiam
Copy link
Contributor

bodiam commented Jul 22, 2015

Hi Dan, I was being unclear. I know it only does basic parsing of bold/italic/etc. However, my question was if this version already does that, or if more IntelliJ components are needed to get the basic highlighting visible in IntelliJ.

@mojavelinux
Copy link
Member

Gotcha. I'm quite curious myself. I'll try to fire it up IntelliJ soon to give it spin.

@yole
Copy link
Contributor Author

yole commented Jul 22, 2015

It already highlights comments, headings and listing blocks.

@bodiam
Copy link
Contributor

bodiam commented Jul 22, 2015

Super! Can you also do bold, and give me some instructions on what you did? Then I can repeat the same for italic, strikethrough, inline code, etc.

On 22 Jul 2015, at 09:00, Dmitry Jemerov notifications@github.com wrote:

It already highlights comments, headings and listing blocks.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants