Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix auto-generated image filenames with diag- #63

Closed
danyill opened this issue May 10, 2020 · 2 comments · Fixed by #65
Closed

Prefix auto-generated image filenames with diag- #63

danyill opened this issue May 10, 2020 · 2 comments · Fixed by #65

Comments

@danyill
Copy link
Contributor

danyill commented May 10, 2020

As pointed out in #48, asciidoctor-diagram prefixes auto-generated image filenames with diag-

I'd be keen to have the diag- prefix in asciidoctor-kroki as a way of namespacing the generated images which don't have an explicit filename (for instance useful if one wished to include in a .gitignore).

@ggrossetie
Copy link
Member

I'd be keen to have the diag- prefix in asciidoctor-kroki as a way of namespacing the generated images which don't have an explicit filename (for instance useful if one wished to include in a .gitignore).

That's a very good point and it will get us one step closer to Asciidoctor diagram 👍

@anb0s
Copy link
Contributor

anb0s commented May 10, 2020

May be it would be also good to have it configured? E.g. kroki-fetch-diagram-prefix default set to diag- ? Only for auto-generated file-names... so i would set it to generated- or if possible generated/ to have it in an imgdir subfolder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants