Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct all references to render by convert #376

Closed
abelsromero opened this issue Nov 6, 2018 · 2 comments
Closed

Correct all references to render by convert #376

abelsromero opened this issue Nov 6, 2018 · 2 comments
Labels
documentation
Milestone
2.0.0

Comments

@abelsromero
Copy link
Member

abelsromero commented Nov 6, 2018 •
edited

To keep consistency, all references in code (#375), tests & docs to render (and derivatives) should be replaced by convert (e.g convertion...).

NOTE: In docs we should point to the fact that the concept was previously mentioned as render to avoid confusion for people checking docs after some time.
@abelsromero abelsromero added this to the 1.6.0 milestone Nov 6, 2018
@abelsromero
Copy link
Member Author

Note to self
Given some logging messages use the term render instead of conversion this change cannot be fully implemented without breaking backward compatibility. That's because we are aware some people have been using this messages to custom validations.

@abelsromero
Copy link
Member Author

I have decided to go full change with it. The reason for 2.0.0 is remove "legacy" elements and it's been announced for 1h year.

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue Jun 15, 2020
@abelsromero
closes asciidoctor#376: replaces use of word render by convert in REA…
18449f8 
…DME and code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@abelsromero