Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of reflection in AsciidoctorJExtensionRegistry #568

Closed
1 of 4 tasks
abelsromero opened this issue Jan 15, 2022 · 0 comments · Fixed by #596
Closed
1 of 4 tasks

Remove use of reflection in AsciidoctorJExtensionRegistry #568

abelsromero opened this issue Jan 15, 2022 · 0 comments · Fixed by #596
Labels
3.0.0
Milestone
3.0.0

Comments

@abelsromero
Copy link
Member

abelsromero commented Jan 15, 2022 •
edited

What is this issue about?

  • Bug report
  • Feature request
  • Question
  • Maintenance task

Description
Use of reflection to support AsciidoctorJ compatibility was introduced in #255 (Sept 2016) to support v1.6.x. Currently we no longer support that version of Asciidoctorj so code can be simplified.

To avoid unnecessary risks, this will be staged for v3.x.
@abelsromero abelsromero added this to the 3.0.0 milestone Jan 15, 2022
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue Aug 25, 2022
@abelsromero
Replace reflection by direct JavaExtensionRegistry calls
0867747 
* Stops any possible usage of AsciidoctorJ v1.6.x (long not supported)
* Fixes issue where registering a non-Processor class was ignored without error
* Small improvements to JavaDocs

closes asciidoctor#568
@abelsromero abelsromero mentioned this issue Aug 25, 2022
Merged
8 tasks
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue Aug 25, 2022
@abelsromero
Replace reflection by direct JavaExtensionRegistry calls
b8e7ed0 
* Stops any possible usage of AsciidoctorJ v1.6.x (long not supported)
* Fixes issue where registering a non-Processor class was ignored without error
* Small improvements to JavaDocs

closes asciidoctor#568
abelsromero added a commit that referenced this issue Aug 25, 2022
@abelsromero
Replace reflection by direct JavaExtensionRegistry calls (#596)
59cd841 
* Stops any possible usage of AsciidoctorJ v1.6.x (long not supported)
* Fixes issue where registering a non-Processor class was ignored without throwing exception
* Small improvements to JavaDocs

closes #568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0.0
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Replace reflection by direct JavaExtensionRegistry calls abelsromero/asciidoctor-maven-plugin
1 participant
@abelsromero