-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource filtering fix #226
Resource filtering fix #226
Conversation
comments? |
<include>**/*.jpg</include> | ||
<include>**/*.gif</include> | ||
<exclude>**/.svn</exclude> | ||
<!-- (Optional) Directory to copy to. By default uses the option `sourceDirectory` --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment is correct. The resources aren't copied to the source directory but rather the output directory, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading it again I think that the overall section is not clear. I propose the next text.
- Replaced first line telling that if resources are not set
all resources inside
sourceDirectoryare copied
- Corrected descriptions for and
resources:: list of resource files to copy to the output directory (e.g., images, css). The configuration follows the same patterns as the `maven-resources-plugin`. If not set, all resources inside `sourceDirectory` are copied
+
[source, xml]
----
<resources>
<resource>
<!-- (Mandatory) Directory to copy from. Paths are relative to maven's ${baseDir} -->
<directory>DIRECTORY</directory>
<!-- (Optional) Directory to copy to. By default uses the option `outputDirectory` -->
<targetPath>OUTPUT_DIR</targetPath>
<!-- (Optional) NOTE: SVN, GIT and other version control files are excluded by default, there's no need to add them -->
<excludes>
<exclude>**/.txt</exclude>
</excludes>
<!-- (Optional) If not set, includes all files but default exceptions mentioned -->
<includes>
<include>**/*.jpg</include>
<include>**/*.gif</include>
</includes>
</resource>
<resource>
...
<resources>
----
Sorry to ask, but what do you think of the proposals? |
@mojavelinux I am a bit confused, I see the 'thumbs' up in the issue, but since it does not show the dat I am not sure if this has been review. Is it good to merge? |
I didn't think about the fact that the reaction icon doesn't show the date. When I'm giving a 👍 to say "proceed with merge" I'll use a comment instead. In this case, I was giving the thumbs up to merge. |
Good to know I did not screw up 😄 |
Not at all. You're doing fantastic, both on the code and communicating.
We're so lucky to have you at the lead!
|
This PR includes the fixes discussed in issue #187.
The required libraries to enable filtering have been added and now it's possible to use it. Hovewer, this is not exposed in the documentation.
Here is the list of changes in this PR:
maven-resource-plugin
configuration and explain the supported options. Note that using only without works also, I guess it's my gradle side that preffers it.sourceDocumentExtension
, these were also copied. Now they are excluded.