-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #244 #245
Fixed #244 #245
Conversation
As I mentioned in the other thread, let's just update the cache: cache:
- C:\maven
- C:\Users\appveyor\.m2 |
Shouldn't we cache just the repo folder ?
If someday we want to tinker with |
We are caching C:\maven because that is where we extracted Maven. I think we can avoid having to download Maven each time if it is cached. However.... I think we should have an environment variable for the version of Maven we are using. We would then only have to change one value and it would a) download the right version and b) only cache the version we are using. wdyt? |
Downloading Maven and using it from a cache is something different than the dependencies which have been downloaded. The download of Maven is not a problem. Apart from that you can the maven wrapper instead of doing this on your own...https://github.com/mojohaus/buildnumber-maven-plugin/blob/master/.travis.yml but this is a separate issue.. |
I like the idea of using the Maven wrapper! |
Maven Wrapper does not support Java6, it's scheduled for 1.6.0 though (#204) |
But I don't think the AppVeyor tests run on Java 6, so it's safe to use
there.
|
If you correctly configure toolchain its not a problem at all... |
I can look into this tomorrow if everyone agrees. Both updating the cache and setting the wrapper for AppVeyour only. |
Just an update, Appveyor ships with maven 3.3.9 and Java 6 now, using both is not compatible of course. I am seeing to replace the default version to avoid issues due to AppVeyor changes. |
I created this PR #272. |
Closing with PR #272 |
o Configured maven to use the local build cache as
Maven cache.