Fixed #244

[khmarbaise]

o Configured maven to use the local build cache as
Maven cache.

[coveralls]

Coverage remained the same at 60.053% when pulling d1abc57 on khmarbaise:issue-244 into a15f77d on asciidoctor:master.

[mojavelinux]

As I mentioned in the other thread, let's just update the cache:

cache:
  - C:\maven
  - C:\Users\appveyor\.m2

[abelsromero]

Shouldn't we cache just the repo folder ?

C:\\Users\\appveyor\\.m2\\repository

If someday we want to tinker with settings.xml we shouldn't cache it.

[mojavelinux]

We are caching C:\maven because that is where we extracted Maven. I think we can avoid having to download Maven each time if it is cached. However....

I think we should have an environment variable for the version of Maven we are using. We would then only have to change one value and it would a) download the right version and b) only cache the version we are using. wdyt?

[khmarbaise]

Downloading Maven and using it from a cache is something different than the dependencies which have been downloaded. The download of Maven is not a problem. Apart from that you can the maven wrapper instead of doing this on your own...https://github.com/mojohaus/buildnumber-maven-plugin/blob/master/.travis.yml but this is a separate issue..

[mojavelinux]

I like the idea of using the Maven wrapper!

[abelsromero]

Maven Wrapper does not support Java6, it's scheduled for 1.6.0 though (#204)

[mojavelinux]

But I don't think the AppVeyor tests run on Java 6, so it's safe to use there.

[khmarbaise]

If you correctly configure toolchain its not a problem at all...

[abelsromero]

I can look into this tomorrow if everyone agrees. Both updating the cache and setting the wrapper for AppVeyour only.
I'd like to include this for next release 😄

[abelsromero]

Just an update, Appveyor ships with maven 3.3.9 and Java 6 now, using both is not compatible of course. I am seeing to replace the default version to avoid issues due to AppVeyor changes.
For instance, a few days after releasing this version they did a rollback and projects using the installed maven started to fail.

[abelsromero]

I created this PR #272.
I kind of digressed from the original idea, so I am open to any comment.

[abelsromero]

Closing with PR #272