Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #246 #247

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Fixed #246 #247

merged 1 commit into from
Jul 20, 2016

Conversation

khmarbaise
Copy link
Contributor

o Added configuration for cache in travis build to prevent
downloading of artifact for every build.

@coveralls
Copy link

coveralls commented Jul 17, 2016 •
edited

Coverage Status

Coverage remained the same at 60.053% when pulling f597b35 on khmarbaise:issue-246 into a15f77d on asciidoctor:master.

@mojavelinux
Copy link
Member

Can you use 2 spaces instead of 4 to indent? Also, we like indent the array entries.

cache:
  directories:
    - $HOME/.m2

@khmarbaise
Copy link
Contributor Author

Changing to 2 spaces no problem. Can you explain what you mean by , we like indent the array entries?

@mojavelinux
Copy link
Member

Meaning there should be two spaces before the hyphen (offset from the parent).

@khmarbaise
Fixed #246
d3fd09c 
 o Added configuration for cache in travis build to prevent
   downloading of artifact for every build.
@mojavelinux
Copy link
Member

You got it!

@khmarbaise
Copy link
Contributor Author

Thanks for explanation...

@coveralls
Copy link

coveralls commented Jul 19, 2016 •
edited

Coverage Status

Coverage remained the same at 60.0% when pulling d3fd09c on khmarbaise:issue-246 into 47d6559 on asciidoctor:master.

@coveralls
Copy link

coveralls commented Jul 19, 2016 •
edited

Coverage Status

Coverage remained the same at 60.0% when pulling d3fd09c on khmarbaise:issue-246 into 47d6559 on asciidoctor:master.

@abelsromero abelsromero merged commit 19f3e49 into asciidoctor:master Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khmarbaise @coveralls @mojavelinux @abelsromero