fixes #264 - adding sourcemap, catalog_assets and template_cache options #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_cache options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR also adds better explanations for other options and puts all option configuration into a single method.
No tests are included since validation of those options require Asciidoctorj 1.6.0. When this is released, tests using Java extensions can be added.
Options are set using property names due to them not being available in OptionsBuilder.
Note, that at least, I have validated the code using an external project that uses AsciidoctorJ 1.6.0-alpha.3. Seeing 1.5.4 against 1.6.0 API has made me appreciate even more the work of Robert.