Improved Tips & Tricks section with an example of header attributes #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojavelinux
reviewed
Nov 30, 2016
| <attributes> | ||
| ... | ||
| <revnumber>${project.version}</revnumber> | ||
| <revdate>${maven.build.date}</revdate> |
There was a problem hiding this comment.
This should actually be maven.build.timestamp...or we should explain how to get Maven to expose the build date. Maybe even suggest integrating with the Maven git plugin. Otherwise, people are going to ask by maven.build.date doesn't work.
There was a problem hiding this comment.
I'd rather keep the tip simple and void other plugins integration.
Instead I fixed the use of date by timestamp property and also added how to deifne the date format.
|
Good. I didn't realize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
· As a closure for #278 I added the resolution into the tips & trick section of the README document.
· Added brief text descriptions of the different Tips&Tricks.
· Removed Tip note about use of
revnumberinPassing POM properties. I consider that the new tip is more elegant and having both can create some confusion.