Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced '_' by '-' as maven properties separator for site mojo #304

Conversation

abelsromero
Copy link
Member

Includes:

  • Replaces separator with hyphon as commented by @mojavelinux
  • Integration test to validate properties replacement with site mojo

Note: I did no include the idea of adding pom- as prefix. Seems excessive and overly complicated, but I am open to suggestions.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.025% when pulling 4fd994c on abelsromero:use_hyphen_instead_of_underscore_for_maven_properties_separator into d18f999 on asciidoctor:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.025% when pulling 4fd994c on abelsromero:use_hyphen_instead_of_underscore_for_maven_properties_separator into d18f999 on asciidoctor:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.025% when pulling 4fd994c on abelsromero:use_hyphen_instead_of_underscore_for_maven_properties_separator into d18f999 on asciidoctor:master.

@abelsromero abelsromero merged commit 85bf0ff into asciidoctor:master Aug 3, 2017
@abelsromero abelsromero deleted the use_hyphen_instead_of_underscore_for_maven_properties_separator branch September 16, 2017 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants