New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #329 - adds treatment to allow relative baseDir on the site #331

Merged

abelsromero merged 1 commit into asciidoctor:master from abelsromero:fix/issue_329

Jan 16, 2018

Member

abelsromero commented Jan 14, 2018

Just added treatment for baseDir in the site plugin.
Maven replacement DO work, added that to the integration test.

As a note to self, in case we need to apply replacements manually, can be done with PluginParameterExpressionEvaluator.


          fixes asciidoctor#329

be580fc

coveralls commented Jan 14, 2018 •

edited

Loading

Coverage decreased (-0.04%) to 65.96% when pulling be580fc on abelsromero:fix/issue_329 into fe0f0f9 on asciidoctor:master.

abelsromero merged commit 49fb85f into asciidoctor:master

abelsromero mentioned this pull request

problem with maven-site-plugin 3.7 and asciidoc 1.5.6. #327

Closed

abelsromero added this to the 1.5.7 milestone

abelsromero deleted the fix/issue_329 branch

July 19, 2018 13:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment