Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #348 outputFile is now relative to outputDirectory + README improvements #352

Conversation

abelsromero
Copy link
Member

The final solutions has been extremely simple.
Just use a String in the setter to keep relative path when set, otherwise maven always inserts an absolute path, rest was already implemented.

Added two integration tests and some notes to the README about outputDirectory and how to run tests.

@coveralls
Copy link

coveralls commented Jun 17, 2018

Coverage Status

Coverage decreased (-0.08%) to 65.92% when pulling c22ecea on abelsromero:fix/348_fix_relative_use_of_outputFile into 103f6c4 on asciidoctor:master.

@abelsromero abelsromero merged commit 910b66e into asciidoctor:master Jun 22, 2018
@abelsromero abelsromero deleted the fix/348_fix_relative_use_of_outputFile branch May 31, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants