Mark BuildMojo as threadSafe #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This annotation will remove a maven build warning. Resolves: #326
|
Hmm. Is there a meaningful test which I can add for my pull request? |
|
We could try a |
added 3 commits
August 20, 2018 15:28
All three modules produces the same result. If the content is mixed during the parallel execution the results will be different and the test fails.
Set 'headerFooter' to 'false'. The generated html files must not contain timestamps.
|
I think now I got it 😁 |
|
I guess that should be enough 👍 |
|
@abelsromero Any plans when 1.5.7 will be released? |
|
Only pending thing is #363. Since is a long requested feature I'd really appreciate some feedback :% but I'd probably merge this weekend regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annotation will remove a maven build warning.
Resolves: #326