Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes sourceHighlighter mojo configuration in favour of attributes #432

Conversation

abelsromero
Copy link
Member

This PR:

  • Removes the sourceHighlighter configuration property
  • Updates tests accordingly
  • Updates README accordingly

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 69.659% when pulling 365a067 on abelsromero:refactor/remove-sourceHighlighter-configuration into f55a6ab on asciidoctor:master.

@abelsromero abelsromero merged commit a5a81b2 into asciidoctor:master May 31, 2020
@abelsromero abelsromero added this to the 2.0.0 milestone Jun 20, 2020
@nagromc
Copy link

nagromc commented Jul 3, 2020

To those who may be wondering how to migrate to the new way of highlight their snippets, check out this page.

The README.adoc has been updated, but not the official webpage. Caused me head scratching for an hour 😅

@abelsromero
Copy link
Member Author

Thanks for the heads up! Since you found it, you can create a PR to fix the url in https://github.com/asciidoctor/asciidoctor.org/blob/576efc0243b824c5f53f25ff39ac66c3f7ea732b/docs/asciidoctor-maven-plugin.adoc. I think we only need to fix the version 1.5.7.1 by 2.0.0.

@abelsromero abelsromero deleted the refactor/remove-sourceHighlighter-configuration branch July 14, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants