Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject maven properties in asciidoctor mojo #459

Conversation

abelsromero
Copy link
Member

This PR automatically injects maven properties as attributes (replacing . by -).
This feature is already present in the site integration, so it makes sense to apply it here.

This PR contains:

  • Implementation resing same code as site module
  • Unit test
  • IT test
  • Updated README. We could remove a section to make things simpler now

@abelsromero abelsromero force-pushed the feature/inject-maven-properties-in-AsciidoctorMojo branch from fd2e788 to b3de456 Compare July 14, 2020 19:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 75.202% when pulling b3de456 on abelsromero:feature/inject-maven-properties-in-AsciidoctorMojo into 30379a5 on asciidoctor:master.

@abelsromero abelsromero merged commit b7f4c34 into asciidoctor:master Jul 14, 2020
@abelsromero abelsromero deleted the feature/inject-maven-properties-in-AsciidoctorMojo branch August 4, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants