Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto refresh files individually #474

Conversation

abelsromero
Copy link
Member

Related to #472

Make it so that auto-refresh mojo only converts modified or newly created files. This is far more efficient and more importantly, will offer for a much responsive experience for users.

This PR contains:

  • Refactor of AsciidoctorMojo so all constructions logic can be applied to individual files.
  • Added message and skip logic when no sources are found. This is not treated as error and allows finishing sooner, so may help usign having problems with configurations.
  • Modified messages in RefreshMojo:
    • "File ..." has been changed to "Source file ..." to better distinguish between AsciiDoc sources and resources.
    • "Re-converted" has been removed since the reuse of the AsciidoctorMojo already shows "Converted ..." message
    • "doc" has been replaced by "document"

PS: Still need to see how to deal with deleted files. That includes renaming a file, which is triggered as a creation + deletion.

@abelsromero abelsromero force-pushed the feature/auto-refresh-files-individually branch from d08ed76 to 0987c07 Compare July 27, 2020 23:01
@coveralls
Copy link

coveralls commented Jul 27, 2020

Coverage Status

Coverage increased (+0.6%) to 79.476% when pulling 0987c07 on abelsromero:feature/auto-refresh-files-individually into 10b2899 on asciidoctor:master.

@abelsromero abelsromero merged commit f25c0c0 into asciidoctor:master Jul 28, 2020
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jul 28, 2020
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jul 28, 2020
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jul 28, 2020
@abelsromero abelsromero deleted the feature/auto-refresh-files-individually branch August 4, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants