Adds synchronization of resources for refresh mojo #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
changed the title
abelsromero
force-pushed
the
feature/synchronize-resources-in-refresh-mojo
branch
2 times, most recently
from
5acef2d
to
4c1883b
Compare
abelsromero
force-pushed
the
feature/synchronize-resources-in-refresh-mojo
branch
from
4c1883b
to
9a11bc1
Compare
|
Side note, with the new tests, build time has increased considerably |
abelsromero
force-pushed
the
feature/synchronize-resources-in-refresh-mojo
branch
from
e879b85
to
254af74
Compare
…d excludes are set
abelsromero
changed the title
|
PR ready! |
|
The problem with coverage reports does not seem to be a random thing. A workarround is available, but we should try to see the real reason. |
abelsromero
force-pushed
the
feature/synchronize-resources-in-refresh-mojo
branch
from
d1d1e05
to
538a965
Compare
|
Fixed the issues with jacoco. It required some changes in the http-mojo. |
abelsromero
force-pushed
the
feature/synchronize-resources-in-refresh-mojo
branch
from
538a965
to
6471cd1
Compare
abelsromero
force-pushed
the
feature/synchronize-resources-in-refresh-mojo
branch
from
6471cd1
to
73d1540
Compare
|
+3 % coverage 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Adds efficient synchronization of resources for refresh mojo.
Are there any alternative ways to implement this?
*FileAlterationListenerAdaptorhierarchy has some duplication but its a tradeoff I think is worth. The other alterntive is making some complex solutions with several lambdas or create abstract methods to customize log messages.Are there any implications of this pull request? Anything a user must know?
Closes #472
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc