Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoids docInfo files from being copied in refresh mojo #480

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Replicates the logic from process-asciidoc mojo that prevents docInfo files from being copied into the output directory.

Are there any alternative ways to implement this?
Following previous pattern, files that are not required in output ar filtered by ResourceCopyFileAlterationListenerAdaptor using a filename regular expression.
To make the pattern easier to mantain the logic has been extracted into a class ResourcesPatternBuilder with proper unit tests for it.

Are there any implications of this pull request? Anything a user must know?
Also includes:

  • Moved all constants related with extentions, and file patterns to AsciidoctorFileScanner
  • Minnor refactoring of AsciidoctorFileScanner. Mostly formatting.

Is it related to an existing issue?

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the feature/do-not-copy-special-resources-in-refresh-mojo branch 2 times, most recently from bafc14f to 9605dc0 Compare August 5, 2020 17:51
@coveralls
Copy link

coveralls commented Aug 5, 2020

Coverage Status

Coverage increased (+0.1%) to 82.702% when pulling eeb2cd2 on abelsromero:feature/do-not-copy-special-resources-in-refresh-mojo into 460e1b9 on asciidoctor:master.

@abelsromero abelsromero force-pushed the feature/do-not-copy-special-resources-in-refresh-mojo branch from 9605dc0 to eeb2cd2 Compare August 5, 2020 17:53
@abelsromero abelsromero merged commit a61dd5e into asciidoctor:master Aug 6, 2020
@abelsromero abelsromero deleted the feature/do-not-copy-special-resources-in-refresh-mojo branch September 14, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants