Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps maven-javadoc-plugin to latest 3.2.0 #481

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Originally maven-javadoc-plugin version configuration, using the version defined in <pluginManagement>.
But also upgrades the version to latest v3.2.0.

Are there any alternative ways to implement this?
Given the plugin is used only once, could define it explicitely.
But for consistency I'd rather have all maven plugin version defined togetherd under pluginManagement.

Are there any implications of this pull request? Anything a user must know?
No.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the feature/bump-maven-javadoc-plugin-to-latest-3.2.0 branch from 847addf to 87f77f0 Compare August 30, 2020 17:55
@coveralls
Copy link

coveralls commented Aug 30, 2020

Coverage Status

Coverage remained the same at 82.702% when pulling 87f77f0 on abelsromero:feature/bump-maven-javadoc-plugin-to-latest-3.2.0 into a61dd5e on asciidoctor:master.

@abelsromero abelsromero merged commit 5a7430d into asciidoctor:master Aug 30, 2020
@abelsromero abelsromero deleted the feature/bump-maven-javadoc-plugin-to-latest-3.2.0 branch August 31, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants