Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #468: adds first life refresh in http mojo #483

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Adds official support to the http mojo that offers life refresh + http publication.

Are there any alternative ways to implement this?
Yes, as explainen in issue #468.

Are there any implications of this pull request? Anything a user must know?
Documentation is becoming convoluted. After release we need to consider building some site with antora.
I have become disenchanted with maven internals, and I don't consider a normal maven site a good option.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero
Copy link
Member Author

I'll let this open for at least 24h to read the docs tomorrow.

@coveralls
Copy link

coveralls commented Sep 3, 2020

Coverage Status

Coverage increased (+2.3%) to 84.971% when pulling 38f7bd4 on abelsromero:feature/468/complete-http-life-refresh into 14e0635 on asciidoctor:master.

@abelsromero abelsromero force-pushed the feature/468/complete-http-life-refresh branch from fb98ea9 to 7afe8b6 Compare September 5, 2020 20:53
@abelsromero
Copy link
Member Author

Made a second pass of the docs, tomorrow final read and merge.

@abelsromero abelsromero force-pushed the feature/468/complete-http-life-refresh branch from 7afe8b6 to 7a48174 Compare September 6, 2020 19:54
@abelsromero abelsromero force-pushed the feature/468/complete-http-life-refresh branch from 7a48174 to 38f7bd4 Compare September 6, 2020 20:04
@abelsromero abelsromero merged commit 08fc4e0 into asciidoctor:master Sep 6, 2020
@abelsromero abelsromero deleted the feature/468/complete-http-life-refresh branch September 14, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants