Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #204: adds maven wrapper and uses it in CI solutions #484

Merged

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Adds maven wrapper to:

  • Make building easier for dev
  • Ensure supported maven version for CI

Are there any alternative ways to implement this?
No

Are there any implications of this pull request? Anything a user must know?
No. In fact people may still use normal maven given its track record of stability.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@coveralls
Copy link

coveralls commented Sep 6, 2020

Coverage Status

Coverage remained the same at 84.971% when pulling af1bf41 on abelsromero:feature/204/adds-maven-wrapper into 08fc4e0 on asciidoctor:master.

@abelsromero abelsromero merged commit a8a1d7e into asciidoctor:master Sep 8, 2020
@abelsromero abelsromero deleted the feature/204/adds-maven-wrapper branch September 14, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants