Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps Asciidoctorj to 2.4.0 + jRuby to 9.2.12.0 #485

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Upgrades AsciidoctorJ version to latests 2.4.0.

Are there any alternative ways to implement this?
No

Are there any implications of this pull request? Anything a user must know?
Also updates JRuby to the version used by AsciidoctorJ, 9.2.12.0.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the feature/bump-asciidoctorj-to-2-4-0 branch from a2c9e45 to b2dadab Compare September 8, 2020 19:03
@coveralls
Copy link

coveralls commented Sep 8, 2020

Coverage Status

Coverage remained the same at 84.971% when pulling 6321676 on abelsromero:feature/bump-asciidoctorj-to-2-4-0 into a8a1d7e on asciidoctor:master.

@abelsromero
Copy link
Member Author

I've seen some sync issues with refresh tests in github action. Seems to be because sometimes tests run slower, I'll increate the wait time.

@abelsromero abelsromero force-pushed the feature/bump-asciidoctorj-to-2-4-0 branch from b2dadab to 6321676 Compare September 8, 2020 19:23
@abelsromero
Copy link
Member Author

I am rerunning the pipeline to see the ocurrence of the issues seen lately, so far seems very rare.
It annoys me, but right now I'd like to focus on re release, the failures are due to sync and socket problems during tests related to refresh features.
Nothing we should worry or happen in real use.

@abelsromero
Copy link
Member Author

Closed in favour of #486

@abelsromero abelsromero deleted the feature/bump-asciidoctorj-to-2-4-0 branch September 14, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants