Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade netty codec http #511

Merged

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Upgrade netty-codec-http used for http and auto-refresh goals as noted in #508.

Are there any alternative ways to implement this?
No

Are there any implications of this pull request? Anything a user must know?
No, tests (should) ensure no feature is broken.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero changed the title Fix/upgrade netty codec http Upgrade netty codec http Mar 8, 2021
@abelsromero
Copy link
Member Author

After experimenting for some time, I am convinced to just use "squash & merge". It reduces history and more consisten 95% of times.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.971% when pulling 484e477 on abelsromero:fix/upgrade-netty-codec-http into e2fd175 on asciidoctor:master.

@abelsromero abelsromero merged commit 9a3de68 into asciidoctor:master Mar 8, 2021
@abelsromero abelsromero deleted the fix/upgrade-netty-codec-http branch April 10, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants