Refactor AsciidoctorMojoTest from Groovy to Java #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
refactor/migrate-mojoTest-to-Java
branch
from
c15e596
to
09d919b
Compare
|
Re-organized some tests under |
abelsromero
force-pushed
the
refactor/migrate-mojoTest-to-Java
branch
3 times, most recently
from
00eefaf
to
74c797b
Compare
|
Pendind squash, but code is up for review |
abelsromero
changed the title
abelsromero
force-pushed
the
refactor/migrate-mojoTest-to-Java
branch
3 times, most recently
from
496f7c9
to
e7009cc
Compare
|
AppVeyour error is the random network I've never been able to narrow down 😞 |
abelsromero
force-pushed
the
refactor/migrate-mojoTest-to-Java
branch
from
e7009cc
to
e0ef5a7
Compare
* Split tests into AsciidoctorMojoTest and AsciidoctorIntegrationTest * Rewrite AsciidoctorMojoTest to Java using Junit4 + Assertj * Automated output directory creation to avoid creation/cleanup on every test * Created `AsciidoctorAsserter` to easily validate converted documents
abelsromero
force-pushed
the
refactor/migrate-mojoTest-to-Java
branch
from
e0ef5a7
to
cdbc130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Make code more approachable by migrating the tests to Java from Groovy.
Nothing bad about Groovy, but JUnit + AssertJ have come to offer similar ease of use.
In the long term, also simplifies the build by removing groovy compilation steps.
Are there any alternative ways to implement this?
I am taking the opportunity to review the tests to remove duplication and unnecessary tests. But overall is a as-is migration.
Are there any implications of this pull request? Anything a user must know?
No
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc