Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AsciidoctorMojoExtensionsTest from Groovy to Java #515

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Make code more approachable by migrating the tests to Java from Groovy.
Nothing bad about Groovy, but JUnit + AssertJ have come to offer similar ease of use.
In the long term, also simplifies the build by removing groovy compilation steps.

Are there any alternative ways to implement this?
I am taking the opportunity to review the tests to remove duplication and unnecessary tests. But overall is a as-is migration.

Are there any implications of this pull request? Anything a user must know?
No

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@coveralls
Copy link

coveralls commented Mar 14, 2021

Coverage Status

Coverage decreased (-0.5%) to 83.104% when pulling bb5c0bd on abelsromero:refactor/migrate-AsciidoctorMojoExtensionsTest-to-java into 1ec052c on asciidoctor:master.

@abelsromero abelsromero force-pushed the refactor/migrate-AsciidoctorMojoExtensionsTest-to-java branch from dfd9666 to aa7092e Compare March 15, 2021 19:58
@abelsromero abelsromero marked this pull request as ready for review March 15, 2021 20:00
@abelsromero abelsromero force-pushed the refactor/migrate-AsciidoctorMojoExtensionsTest-to-java branch from aa7092e to bb5c0bd Compare March 15, 2021 20:02
@abelsromero abelsromero merged commit c8d3994 into asciidoctor:master Mar 18, 2021
@abelsromero abelsromero deleted the refactor/migrate-AsciidoctorMojoExtensionsTest-to-java branch April 10, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants