Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AsciidoctorZipMojoTest from Groovy to Java #518

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Make code more approachable by migrating the tests to Java from Groovy.
Nothing bad about Groovy, but JUnit + AssertJ have come to offer similar ease of use.
In the long term, also simplifies the build by removing groovy compilation steps.

Are there any alternative ways to implement this?
I am taking the opportunity to review the tests to remove duplication and unnecessary tests. But overall is a as-is migration.

Are there any implications of this pull request? Anything a user must know?
No

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the refactor/migrate-AsciidoctorZipMojoTest-to-java branch from 9b1eb49 to b58c045 Compare March 22, 2021 22:35
@coveralls
Copy link

coveralls commented Mar 22, 2021

Coverage Status

Coverage decreased (-0.9%) to 81.827% when pulling 7edba27 on abelsromero:refactor/migrate-AsciidoctorZipMojoTest-to-java into c4dd5ba on asciidoctor:master.

@abelsromero abelsromero force-pushed the refactor/migrate-AsciidoctorZipMojoTest-to-java branch from b58c045 to 6b21dbd Compare March 22, 2021 22:48
@abelsromero abelsromero force-pushed the refactor/migrate-AsciidoctorZipMojoTest-to-java branch from 6b21dbd to 7edba27 Compare March 23, 2021 20:32
@abelsromero abelsromero merged commit 079850b into asciidoctor:master Mar 23, 2021
@abelsromero abelsromero deleted the refactor/migrate-AsciidoctorZipMojoTest-to-java branch April 10, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants