Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to extension api documentation #523

Merged

Conversation

djarnis73
Copy link
Contributor

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Improve documentation

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc
I don't think this warrants a changelog entry.

@coveralls
Copy link

coveralls commented Apr 7, 2021

Coverage Status

Coverage remained the same at 81.827% when pulling 756d076 on djarnis73:fix-broken-links-to-extensions-api into 329c13a on asciidoctor:master.

@abelsromero
Copy link
Member

Thanks a lot!
Do you care updating the CHANGELOG too? You'll have to add Documentation section for the current Unreleased.

@djarnis73
Copy link
Contributor Author

Thanks a lot!
Do you care updating the CHANGELOG too? You'll have to add Documentation section for the current Unreleased.

Personally I think this change is so insignificant that it does not warrant en entry in the changelog, but I will add one if you prefer.

Best regards Jens

@abelsromero
Copy link
Member

Personally I think this change is so insignificant that it does not warrant en entry in the changelog, but I will add one if you prefer.

Something was not working and now it is, I think is relevant enough.

@abelsromero abelsromero merged commit 2c8a3e2 into asciidoctor:master Apr 9, 2021
@djarnis73 djarnis73 deleted the fix-broken-links-to-extensions-api branch April 9, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants