Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting included sources to run full refresh on change #542

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jul 18, 2021

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Fix conversion not happending when included sources where modified in autp-refresh and http mojo.
As discussed in #403 at the end we added a new option available for those mojos to allow users to specify other files to "listen to changes on". On a change or creation, a full rebuild will be done.

Are there any alternative ways to implement this?
Current approach allows users to specify a set of extra sources to monitor.
On change a full rebuild (without copying resources) will happen. A full rebuild is necessary since we don't know which sources are affected.

Are there any implications of this pull request? Anything a user must know?

  1. Creating an extension (include processor or preprocessor) that creates a tree of dependencies to know exactly which files to modify.
    Discarded because custom filters may interfere with other extensions used by users.
  2. Manually parsing all sources as texts files and build such index manually.
    Discarded because configurations that maniputale paths (with basePath for example) and have files with same names may be impossible to properly resolve or we may have to also resort to "full builds".

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the issue-403-run-refresh-on-included-sources branch 5 times, most recently from dfa64af to 788e2f6 Compare July 18, 2021 17:40
@abelsromero abelsromero force-pushed the issue-403-run-refresh-on-included-sources branch from 788e2f6 to 850621c Compare July 18, 2021 17:44
@abelsromero
Copy link
Member Author

I had to increase the timeout for refresh tests for ubuntu-java8. I assume they run slower on than environment for some reason.

@abelsromero abelsromero merged commit 139fcde into asciidoctor:main Jul 18, 2021
@abelsromero abelsromero deleted the issue-403-run-refresh-on-included-sources branch July 19, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant