Fix excluding sources when enclosing parent path starts with _ #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-545-do-no-treat-parent-path-as-sources-path
branch
2 times, most recently
from
d436b31
to
1537d1a
Compare
abelsromero
changed the title
abelsromero
force-pushed
the
issue-545-do-no-treat-parent-path-as-sources-path
branch
from
1537d1a
to
5c3191a
Compare
abelsromero
changed the title
abelsromero
force-pushed
the
issue-545-do-no-treat-parent-path-as-sources-path
branch
2 times, most recently
from
3513c30
to
adbe85b
Compare
abelsromero
force-pushed
the
issue-545-do-no-treat-parent-path-as-sources-path
branch
from
adbe85b
to
030eb7a
Compare
abelsromero
deleted the
issue-545-do-no-treat-parent-path-as-sources-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Fix sources not being included when enclosing path started with
_.That is some directory in the upper path containing the project had the hidden preffix.
The fix is simply checking for paths ONLY in the project path.
Are there any alternative ways to implement this?
No.
Are there any implications of this pull request? Anything a user must know?
Did some formatting and minnor refactors.
Sicne it's first PR after a release, also opens new unreleased section in CHANGELOG.
Is it related to an existing issue?
Fixes Logic change in how paths are validated #545
Finally, please add a corresponding entry to CHANGELOG.adoc