Fix site integration failing with maven-site-plugin v3.10.0 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-564-fails-with-mavensite-3.10.0
branch
3 times, most recently
from
cfd3e94
to
f0e2219
Compare
3 tasks
michael-o
suggested changes
Jan 14, 2022
abelsromero
force-pushed
the
issue-564-fails-with-mavensite-3.10.0
branch
2 times, most recently
from
f2d04ae
to
ffbc0f7
Compare
abelsromero
force-pushed
the
issue-564-fails-with-mavensite-3.10.0
branch
from
ffbc0f7
to
664819b
Compare
This makes maven-site-plugin v3.10.0 the minimum compatible version * Make AsciidoctorDoxiaParser extend AbstractTextParser instad of XhtmlParser * Bump minimum Doxia version to v1.10 * Update maven-site-plugin it test Fixes asciidoctor#564
abelsromero
force-pushed
the
issue-564-fails-with-mavensite-3.10.0
branch
from
664819b
to
d55dd49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Fixes #564
Are there any alternative ways to implement this?
The issue does not appear when overriding
doxia-corev1.11.1 with v1.9.1, so it could be there's some other issue on doxia.However, it is also true
AsciidoctorDoxiaParserextendedXhtmlParserwhich makes no sense and which is consistent with the error that points to invalid XML document (of course AsciiDoc is not XML compatible).Are there any implications of this pull request? Anything a user must know?
doxia-site-rendererhas not yet been release.Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc