Apply 's4u/setup-maven-action' GH action #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-630-test-on-multiple-maven-versions
branch
from
a41e906
to
cc654d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Ensure we properly support a few maven versions. There have been some breaking changes in 3.9.1 that brought this to attention.
Are there any alternative ways to implement this?
We could have a script step installing sdkman and setting mvn in the path.
But this is extra code we'd need to maintain.
Are there any implications of this pull request? Anything a user must know?
Everything is don by
s4u/setup-maven-actionso we are in theory losing some control, but in reality, nothing we really needed. We'll see how it goes.Is it related to an existing issue?
Fixes #630
Finally, please add a corresponding entry to CHANGELOG.adoc