Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven-source-plugin configuration for release #645

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented May 28, 2023

Else, an error reporting the plugin is run twice is shown.

Fixes #644

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

Prevent an error during the release.
It was detected and fixed for v2.2.x during v2.2.4 release.

Are there any alternative ways to implement this?
no

Are there any implications of this pull request? Anything a user must know?
no

Is it related to an existing issue?

  • Yes
  • [] No

#644

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the issue-644-fix-maven-source-release-config branch 3 times, most recently from 6944a13 to dac8f35 Compare May 28, 2023 20:19
Else, an error reporting the plugin is run twice is shown.

Fixes asciidoctor#644
@abelsromero abelsromero merged commit 6859101 into asciidoctor:main May 29, 2023
27 checks passed
@abelsromero abelsromero deleted the issue-644-fix-maven-source-release-config branch December 28, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix maven-source-plugin configuration for releases
1 participant