Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(main) Fix resource copy in multi-module project (#838) #841

Conversation

schastlivcev
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Fix resource copy in multi-module project

Are there any alternative ways to implement this?
None

Are there any implications of this pull request? Anything a user must know?
None

Is it related to an existing issue?

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero
Copy link
Member

ThanKs! I'll have a look as soon as possible, it may take a couple of days though 🙇

Copy link
Member

@abelsromero abelsromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the time, but I am really sorry to say I don't think the approach would not work.
The IT tests are not easy, I can take care of that later if you want. But you should be able to try it in your project installing the plugin locally. Run mvn clean install -DskipTests and configure your project to use version 3.0.1-SNAPSHOT.

If you are curious you can even debug the code from a project running your project with mvnDebug and configuring your IDE to listen to remote debug on port 8000. But don't stress too much, and if you struggle feel free to ask anything.

@abelsromero abelsromero changed the title Fix resource copy in multi-module project (#838) (main) Fix resource copy in multi-module project (#838) Jun 1, 2024
@abelsromero abelsromero merged commit fae65bd into asciidoctor:main Jun 1, 2024
20 checks passed
@abelsromero
Copy link
Member

Thanks, all is fine, I double-checked again branch v2.2.x and we don't need to port it. So we are set.
Since there's a simple workaround I am planning a release asap, but feel free to object if you need this.
I'll start work on the labeled bugs, but those are available for anyone to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource copy in multi-module does not work
2 participants