Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support icon set as prefix on icon target #1365

Closed
mojavelinux opened this issue Nov 2, 2019 · 2 comments
Closed

Support icon set as prefix on icon target #1365

mojavelinux opened this issue Nov 2, 2019 · 2 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.0.beta.8

Comments

@mojavelinux
Copy link
Member

If the icon target starts with a known prefix, use it when resolving the icon name.

icon:fab-twitter[]
@mojavelinux mojavelinux self-assigned this Nov 2, 2019
@mojavelinux mojavelinux added this to the v1.5.0 milestone Nov 2, 2019
@mojavelinux
Copy link
Member Author

Using the icon set as the prefix is already supported for the admonition icons in the theme.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Nov 9, 2019
@mojavelinux
resolves asciidoctor#1365 allow icon set to be specified as prefix on…
5fe0bfe 
… target of icon macro
@mojavelinux
Copy link
Member Author

This should be a fallback scenario when the icon set is not specified. At least, we'll start with that. The preferred syntax is icon:twitter@fab[] or icon:twitter[set=fab].

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Nov 11, 2019
@mojavelinux
resolves asciidoctor#1365 allow icon set to be specified as prefix on…
1f1c6b7 
… target of icon macro
@mojavelinux mojavelinux modified the milestones: v1.5.0, v1.5.0.beta.8 Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.0.beta.8
Development

No branches or pull requests
1 participant
@mojavelinux