Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define underline and line-through roles as built-in custom roles #1393

Closed
mojavelinux opened this issue Nov 16, 2019 · 0 comments
Closed

Define underline and line-through roles as built-in custom roles #1393

mojavelinux opened this issue Nov 16, 2019 · 0 comments
Assignees
@mojavelinux
Labels
improvement
Milestone
v1.5.0.beta.8

Comments

@mojavelinux
Copy link
Member

Currently, the underline and line-through roles are hard-coded. There's no way to customize them, and there's no way to remove them. Instead, they should be defined as built-in custom roles like big and small. This allows the theme to add additional properties to them. It will also pave the way for #812 to be implemented.
@mojavelinux mojavelinux self-assigned this Nov 16, 2019
@mojavelinux mojavelinux added this to the v1.5.0 milestone Nov 16, 2019
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Nov 16, 2019
@mojavelinux
resolves asciidoctor#1393 define line-through and underline roles as …
ff57048 
…built-in custom roles so they can be customized
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Nov 17, 2019
@mojavelinux
resolves asciidoctor#1393 define line-through and underline roles as …
012c8a8 
…built-in custom roles so they can be customized
@mojavelinux mojavelinux modified the milestones: v1.5.0, v1.5.0.beta.8 Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement
Projects
None yet
Milestone
v1.5.0.beta.8
Development

No branches or pull requests
1 participant
@mojavelinux