Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI testing for JRuby on Windows #1520

Closed
slonopotamus opened this issue Jan 25, 2020 · 7 comments
Closed

Add CI testing for JRuby on Windows #1520

slonopotamus opened this issue Jan 25, 2020 · 7 comments
Assignees
@slonopotamus
Milestone
v1.5.0.rc.3

Comments

@slonopotamus
Copy link
Contributor

slonopotamus commented Jan 25, 2020 •
edited

Subj. This is a very fragile environment with its own class of bugs that deserves dedicated testing.
@slonopotamus
Copy link
Contributor Author

Current Windows+JRuby picture: https://github.com/slonopotamus/asciidoctor-pdf/runs/408612060?check_suite_focus=true#step:5:17

@slonopotamus slonopotamus mentioned this issue Jan 25, 2020
Closed
@slonopotamus slonopotamus changed the title Add CI testing on Windows Add CI testing on JRuby+Windows Jan 25, 2020
@slonopotamus slonopotamus changed the title Add CI testing on JRuby+Windows Add CI testing for JRuby on Windows Jan 25, 2020
@slonopotamus
Copy link
Contributor Author

After a bit of fixing, there are only 5 failing tests

@mojavelinux
Copy link
Member

If you rebase, the CLI path test should now be working.

@slonopotamus
Copy link
Contributor Author

I did and yes, it passes now.

@mojavelinux
Copy link
Member

Try again. We should be down to 0. If not, then the redirection just doesn't work on JRuby on Windows and we'll disable it.

@slonopotamus
Copy link
Contributor Author

Oh, we forgot about this PR. Resolved by #1496.

slonopotamus added a commit to slonopotamus/asciidoctor-pdf that referenced this issue Jan 28, 2020
@slonopotamus
resolves asciidoctor#1520 disable pygments.rb on JRuby on Windows bec…
9078389 
…ause it hangs

See asciidoctor/asciidoctor-epub3#253 for more details.
@mojavelinux
Copy link
Member

This is now working.

@mojavelinux mojavelinux modified the milestones: v1.5.0, v1.5.0.rc.3 Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slonopotamus slonopotamus

Labels
None yet
Projects
None yet
Milestone
v1.5.0.rc.3
Development

No branches or pull requests
2 participants
@mojavelinux @slonopotamus