Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author metadata not set when no title page present and using author attribute #1922

Closed
1marc1 opened this issue May 3, 2021 · 2 comments
Closed
Labels
Milestone

Comments

@1marc1
Copy link
Contributor

1marc1 commented May 3, 2021

When a document does not have a title page and the document attribute author is set, then the value of the attribute is not set in the metadata of the resulting PDF file.

If the attribute authors is set, then the value of the attribute is set in the metadata of the resulting PDF file.

Example 1:

:author: Kismet R. Lee
== Test document

Author name is not recorded in metadata.

Example 2:

:authors: Kismet R. Lee
== Test document

Author name is recorded in metadata.

Marc.

@mojavelinux
Copy link
Member

This is a combination between a quirk in how Asciidoctor parses the document header when there is no doctitle and the logic for how the authors are resolved in this converter. Fortunately, I can see a way we can support both cases you cited.

As a side note, when you define a document header, you should always offset it by an empty line.

:author: Kismet R. Lee

== Test document

Author name is not recorded in metadata.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 3, 2021
…nd pdfmark if authors attribute is not set
@1marc1
Copy link
Contributor Author

1marc1 commented May 3, 2021

Thanks Dan, much appreciated as always!

@mojavelinux mojavelinux added this to the v2.0.0 milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants