Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting float attribute on image should set caption max-width to fit-content #2150

Closed
mojavelinux opened this issue May 10, 2022 · 0 comments
Assignees
Milestone

Comments

@mojavelinux
Copy link
Member

In preparation for the fix for #353, the caption on an image that has the float attribute should be restricted to the width of the content (i.e., fit-content). If the max-width key is not set, or it is not fit-content, it should be set to fit-content for that image. If the max-width is already a percentage of the content width (e.g., fit-content(50%)) it should be left unchanged as this is a suitable setting for this scenario.

@mojavelinux mojavelinux self-assigned this May 10, 2022
@mojavelinux mojavelinux added this to the v2.0.0 milestone May 10, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 11, 2022
…h to fit-content if float attribute is set on block image
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 11, 2022
…nt if float attribute is set on block image
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 11, 2022
…nt if float attribute is set on block image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant