Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remote image cache for prawn-svg #223

Closed
mojavelinux opened this issue Jun 24, 2015 · 2 comments
Closed

Enable remote image cache for prawn-svg #223

mojavelinux opened this issue Jun 24, 2015 · 2 comments
Assignees
Milestone

Comments

@mojavelinux
Copy link
Member

mojavelinux commented Jun 24, 2015

Enable the remote image cache for prawn-svg so that remote images are only downloaded once per document. Alternatively, we may want to add integration with open-uri-cached so that these images are cached between runs as well (with smart update detection). We're shooting for the most optimal behavior.

@mojavelinux mojavelinux self-assigned this Jun 24, 2015
@mojavelinux mojavelinux added this to the v1.5.0 milestone Jun 24, 2015
@mojavelinux
Copy link
Member Author

We should also link this cache between the main and scratch document to avoid having two caches. The same is true for the raster image cache (which is already enabled by default).

@mojavelinux mojavelinux added next and removed next labels Jun 27, 2015
@mojavelinux mojavelinux modified the milestones: future, v1.5.0 Jul 21, 2015
@mojavelinux
Copy link
Member Author

We can start by simply enabling the option if the cache-uri attribute is set. I think prawn-svg should integrate it's cache with open-uri/cached, or expose the cache methods. Otherwise, I don't see a way for a deeper integration.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Nov 2, 2019
@mojavelinux mojavelinux modified the milestones: future, v1.5.0 Nov 2, 2019
@mojavelinux mojavelinux modified the milestones: v1.5.0, v1.5.0.beta.8 Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant