Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock ttfunk to 1.7.x in 2.3.x release line #2508

Closed
mojavelinux opened this issue Mar 12, 2024 · 2 comments
Closed

Lock ttfunk to 1.7.x in 2.3.x release line #2508

mojavelinux opened this issue Mar 12, 2024 · 2 comments
Assignees
Milestone

Comments

@mojavelinux
Copy link
Member

ttfunk is the TTF/OTF font library used by Prawn. Prawn only locks ttfunk to the major version 1 (~> 1.0). When ttfunk 1.8.0 was released, Asciidoctor PDF releases in the 2.3.x release line got this upgrade transitively on the install. However, ttfunk 1.8.0 requires Ruby headers (i.e., development libraries to install). This new requirement violates our commitment to adhere to semantic versioning. Therefore, it's necessary to lock ttfunk to 1.7.x and defer the upgrade to the Asciidoctor PDF 3 release.

There has also been at least one report that the ttfunk upgrade causes some glyphs in TTF fonts to not resolve. That's yet another reason to hold it back until we have time to investigate and assess the situation.

@mojavelinux mojavelinux self-assigned this Mar 12, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone Mar 12, 2024
@mojavelinux mojavelinux changed the title Look ttfunk to 1.7.x in 2.3.x release line Lock ttfunk to 1.7.x in 2.3.x release line Mar 12, 2024
@mojavelinux
Copy link
Member Author

Unfortunately, this means the users of Asciidoctor PDF will have to wait until Asciidoctor PDF 3 is released to get the improvements to the OTF font support introduced by ttfunk 1.8.0.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 12, 2024
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 12, 2024
@mojavelinux
Copy link
Member Author

Resolved by 21760a1. This fix will not be added to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant