Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Header/Footer font properties per column #454

Closed
igagis opened this issue May 25, 2016 · 10 comments
Closed

Allow Header/Footer font properties per column #454

igagis opened this issue May 25, 2016 · 10 comments
Assignees

Comments

@igagis
Copy link

igagis commented May 25, 2016

It would be good to be able to specify different fonts/size/style per column position (left/center/right) in header and footer.
Right now it is only possible to change font settings for the whole header or whole footer.

header:
  recto_content:
    center: blah blah
    center_font_family: Courier
@mojavelinux
Copy link
Member

That's reasonable. However, I think we may have to rethink the key structure. We should rename recto_content to recto_page.

header:
  recto_page:
    center:
      content: blah
      font_family: Courier

wdyt?

If you aren't customizing the font, you could write it as:

header:
  recto_page:
    center: blah

In this case, the position is assumed to be the content.

@igagis
Copy link
Author

igagis commented May 25, 2016

Looks OK.
And recto_content could be deprecated but still functional to provide backwards compatibility.

@mojavelinux
Copy link
Member

Yes, I was thinking about backward compatibility. But likely we won't keep it for 1.5.0 since this is still alpha (one of the key reasons we are still in alpha). I'll phase it out maybe in beta.

@mojavelinux
Copy link
Member

Now that I've restructured the keys for the content, I can accommodate the font settings as follows:

header:
  recto:
    center:
      content: blah
      font_family: Courier

I'm going to start by experimenting with font_color as that will be easiest to implement.

Open question: Should we name the segment for face "recto_page" and "verso_page" instead of "recto" and "verso", respectively? (Since I'm remapping the legacy keys, I could still do that without breaking existing themes).

@mojavelinux
Copy link
Member

Note to self: Update the theming guide to document the new order of the theme key segments once this issue is resolved.

@mojavelinux
Copy link
Member

Since there's a lot of terminology surrounding the running content, I'd like to document some of the terms.

  • position - the position of the running content stamp (header or footer)
  • side - the page side (recto for right-hand / odd and verso for left-hand / even)
  • placement - the placement of the column in the 3-column layout (left, center, or right)

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Aug 23, 2016
…in running content

- allow font properties to be set per page side and column in running content
- update theming guide to reflect new structure of keys for running content
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Aug 24, 2016
…in running content

- allow font properties to be set per page side and column in running content
- update theming guide to reflect new structure of keys for running content
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Aug 24, 2016
…in running content

- allow font properties to be set per page side and column in running content
- update theming guide to reflect new structure of keys for running content
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Aug 24, 2016
…in running content

- allow font properties to be set per page side and column in running content
- update theming guide to reflect new structure of keys for running content
@igagis
Copy link
Author

igagis commented Aug 24, 2016

Great!

@mojavelinux
Copy link
Member

@igagis Any thoughts about the key recto vs recto_page?

@igagis
Copy link
Author

igagis commented Aug 24, 2016

@mojavelinux well, recto is shorter, so easier to type. Otherwise, does not matter in my opinion

@mojavelinux
Copy link
Member

Okay, we'll stick with recto/verso for now. Thanks for the input!

fapdash pushed a commit to vogellacompany/asciidoctor-pdf that referenced this issue Dec 13, 2016
…in running content (PR asciidoctor#518)

- allow font properties to be set per page side and column in running content
- update theming guide to reflect new structure of keys for running content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants