Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prawn SVG should only fetch image from URI if allow-uri-read is set #548

Closed
mojavelinux opened this issue Sep 10, 2016 · 0 comments
Closed

Prawn SVG should only fetch image from URI if allow-uri-read is set #548

mojavelinux opened this issue Sep 10, 2016 · 0 comments
Assignees
@mojavelinux
Labels
improvement
Milestone
v1.5.0.alpha.13

Comments

@mojavelinux
Copy link
Member

Prawn SVG should be configured to honor the allow-uri-read setting. In other words, it should only be allowed to make web requests (e.g., fetch an image from a URI) if the allow-uri-read attribute is set via the Asciidoctor API or CLI.

Prawn SVG provides the option enable_web_requests for this purpose. It just needs to be wired to the state of the allow-uri-read attribute.
@mojavelinux mojavelinux added this to the v1.5.0.alpha.13 milestone Sep 10, 2016
@mojavelinux mojavelinux self-assigned this Sep 10, 2016
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Sep 10, 2016
@mojavelinux
resolves asciidoctor#548 only allow prawn-svg to fetch remote images …
5eef576 
…if allow-uri-read is set
fapdash pushed a commit to vogellacompany/asciidoctor-pdf that referenced this issue Dec 13, 2016
@mojavelinux @fapdash
resolves asciidoctor#548 only allow prawn-svg to fetch remote images …
24205da 
…if allow-uri-read is set (PR asciidoctor#549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement
Projects
None yet
Milestone
v1.5.0.alpha.13
Development

No branches or pull requests
1 participant
@mojavelinux