Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes Not Rendering in PDF (but work in HTML) #927

Closed
tajmone opened this issue Aug 30, 2018 · 3 comments
Closed

Footnotes Not Rendering in PDF (but work in HTML) #927

tajmone opened this issue Aug 30, 2018 · 3 comments
Assignees
Labels

Comments

@tajmone
Copy link

tajmone commented Aug 30, 2018

This is somehow related to Issue #85, but not the same.

I have encountered a problem when converting to PDF a Table which contains footnotes. Here is the Table source (adoc source link):

[[table-of-options]]
.Adventure Settings via OPTION
[cols="<20m,<40d,<40d",options="header"]
|===============================================================================
| Option name | Possible values | Default value

| Language
| `English`, `Swedish`, ``German``footnote:[Other non-English languages may be supported in the future depending on demand.]
| `English`

| Width
| 24-255
| 80footnote:[Width and Length is overridden by the actual terminal or window size, if available.]

The problem is with " ``German``footnote:[" and "80footnote:[", which are correctly rendered as footnotes in the HTML backend, but when using Asciidoctor PDF they are not rendered as notes, but the contents of the note are rendered as inline text (withing brackets and preceded by a space):

Language English, Swedish, German [1: Other non-
English languages may be supported
in the future depending on demand.]

and

Width 24-255 80 [2: Width and Length is overridden
by the actual terminal or window size,
if available.]

The only workaround I can come up with is adding a separating space before footnote[, but then that space would show up in the final documents as well (which doesn't look good). In the Documentation examples, no spaces are inserted between the footnote and the word it refers to, but in all examples there is a punctuation mark between them. In real life scenarios, footnotes might be attached directly to a word which is not followed by punctuation, so probably any spaces before the footnote[ macro should be removed in the final rendered document.

The HTML backend handles well the footnotes in the above table, so probably this is a bug in the Asciidoctor PDF backend. Here is a live HTML preview of how the above table is rendered via HTML backend:

Any ideas on a temporary workaround for the problem? (possibly, that doesn't introduce a space between the word and the note number)

@tajmone
Copy link
Author

tajmone commented Aug 30, 2018

This issue is related to #73.

The problem doesn't seem to be the lack of space (or punctuation) before the footnote:[, but how Asciidoctor PDF handles footnotes in Tables.

If I set the columns to a, the notes are rendered in the PDF, but inside the cell (like @Gitward mentions in #73).

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jun 15, 2019
@mojavelinux
Copy link
Member

This was fixed somewhere along the way, perhaps when #85 got fixed. I've submitted a test to verify that behavior.

@mojavelinux mojavelinux self-assigned this Jun 15, 2019
@mojavelinux mojavelinux added this to the v1.5.0.alpha.18 milestone Jun 15, 2019
@tajmone
Copy link
Author

tajmone commented Jun 15, 2019

Great to see this fixed! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants