Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #490 support page layout per page #1026

Closed
wants to merge 1 commit into from
Closed

resolves #490 support page layout per page #1026

wants to merge 1 commit into from

Conversation

darevan
Copy link
Contributor

@darevan darevan commented Apr 17, 2019

This resolves part of #490, which is the ability to use specify the page layout use a block attribute on a page break as noted in #490 (comment).

There is extra work required in being able to set the page margins and page size as currently these are assumed to be consistent across the entire document.

The key limitation of this PR is that the headers and footer are not resized when the layout is changed.

mojavelinux added a commit that referenced this pull request Apr 18, 2019
@mojavelinux
Copy link
Member

Thanks! Merged as c5589cd. I simplified the code slightly and added some tests.

@darevan darevan deleted the issue-490-support-page-layout-per-page branch April 19, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants