enable font_fallbacks support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relate to #58 |
|
The fallback_fonts feature was previously disabled because it was breaking global styling. This was fixed in Prawn 1.2.1 as described in the following section in the release notes: https://github.com/prawnpdf/prawn/wiki/CHANGELOG#fallback-fonts-no-longer-break-global-font-styling It's safe to use this feature. I just confirmed it works as expected. |
|
Thanks for fixing this, @chloerei! |
mojavelinux
added a commit
that referenced
this pull request
Jan 9, 2015
enable font_fallbacks support
|
I'm going to reenable the fallback_fonts in the default asciidoctor theme to use the already provided M+ 1p multilingual font. We know it doesn't cover all CJK characters, but at least it catches some for now. We'll address more complete support as part of #82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let editor can use font fallbacks settings in themes.