Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reveal.js history feature doesn't work with slides rendered by asciidoctor-reveal.js #127

Closed
obilodeau opened this issue Apr 5, 2017 · 3 comments
Closed

reveal.js history feature doesn't work with slides rendered by asciidoctor-reveal.js #127

obilodeau opened this issue Apr 5, 2017 · 3 comments
Labels
🐛 bug 💎 ruby/gem
Milestone
1.1.0

Comments

@obilodeau
Copy link
Member

The setting :revealjs_history: true doesn't work.

Jumping directly to slides w/o a title is working with history enabled. These are replaced with a number.

What doesn't work is jumping directly to slides with a title.

To reproduce:

Expected: that you arrived at the title slide "Malboxes"

Actual result: You land on the first slide of the deck.

Links to slide number works though: http://gosecure.github.io/presentations/2016-12-01_botconf/malboxes.html#/2
@obilodeau
Copy link
Member Author

Related to #99

@obilodeau obilodeau added this to the 1.1.0 milestone Aug 19, 2017
@obilodeau
Copy link
Member Author

I have a fix ready. Expect PR soon.

obilodeau added a commit to obilodeau/asciidoctor-reveal.js that referenced this issue Sep 28, 2017
@obilodeau
Reveal.js compatible slide id generation fixes history feature (ascii…
1985aa2 
…doctor#127)
@obilodeau obilodeau mentioned this issue Sep 28, 2017
Merged
obilodeau added a commit that referenced this issue Oct 1, 2017
@obilodeau
Merge pull request #150 from obilodeau/fix-revealjs-history
2646ea9 
Reveal.js compatible slide id generation fixes history feature (#127)
@obilodeau
Copy link
Member Author

Fixed with the #150 merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug 💎 ruby/gem
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@obilodeau