Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with Reveal.js 3.5.0 #146

Merged
merged 11 commits into from
Dec 25, 2017
Merged

Sync with Reveal.js 3.5.0 #146

merged 11 commits into from
Dec 25, 2017

Conversation

rahulsom
Copy link
Contributor

There are a lot of things that've shown up in the reveal.js repo.
This brings in the missing configuration properties here.

@obilodeau
Copy link
Member

Please look at the build failures. They are related to your change.

@obilodeau obilodeau added this to the 1.1.0 milestone Sep 28, 2017
@obilodeau
Copy link
Member

Just realized that the README would need adjustments as well.

@obilodeau
Copy link
Member

After some testing, I realize that the defaultTiming settings needs to be entirely optional, otherwise speaker notes always have an annoying per-slide timeout with red warnings.

I'll experiment with trying to avoid that problem later.

@obilodeau
Copy link
Member

Using null works so I'm doing that.

@obilodeau obilodeau changed the title Sync configuration with master of reveal.js Sync with Reveal.js 3.5.0 Oct 6, 2017
@obilodeau obilodeau mentioned this pull request Oct 6, 2017
3 tasks
@obilodeau
Copy link
Member

Just rebased on master. Will test everything manually using both ruby and javascript stacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants